Merge pull request '[macos-runner] Fix build number bump - agvtool was silently no-oping' (#38) from ci/gitea-actions/macos-runner into main

Reviewed-on: Loverde-Company-LTDA/Pedi-Foods-Skip#38

.gitea/workflows/beta.yml

@@ -20,6 +20,7 @@ jobs:
       APPLE_ID: ${{ secrets.APPLE_ID }}
       ITC_TEAM_ID: ${{ secrets.ITC_TEAM_ID }}
       DEVELOPMENT_TEAM: ${{ secrets.DEVELOPMENT_TEAM }}
+      BUILD_NUMBER: ${{ gitea.run_number }}
 
     steps:
       - name: Checkout
@@ -32,11 +33,6 @@ jobs:
           git -c credential.helper= -c http.lowSpeedLimit=1000 -c http.lowSpeedTime=30 clone "$AUTH_URL" .
           git checkout "${{ gitea.sha }}"
 
-      - name: Set build number
-        run: |
-          cd Darwin
-          agvtool new-version -all ${{ gitea.run_number }}
-
       - name: Write App Store Connect API key
         run: |
           cat > Darwin/fastlane/apikey.json <<EOF

.gitea/workflows/release.yml

@@ -20,6 +20,7 @@ jobs:
       APPLE_ID: ${{ secrets.APPLE_ID }}
       ITC_TEAM_ID: ${{ secrets.ITC_TEAM_ID }}
       DEVELOPMENT_TEAM: ${{ secrets.DEVELOPMENT_TEAM }}
+      BUILD_NUMBER: ${{ gitea.run_number }}
 
     steps:
       - name: Checkout
@@ -39,11 +40,6 @@ jobs:
             exit 1
           fi
 
-      - name: Set build number
-        run: |
-          cd Darwin
-          agvtool new-version -all ${{ gitea.run_number }}
-
       - name: Write App Store Connect API key
         run: |
           cat > Darwin/fastlane/apikey.json <<EOF

Darwin/fastlane/Fastfile

@@ -17,12 +17,17 @@ lane :assemble do |options|
   # scope a global override to just one target, and update_code_signing_settings
   # itself can't parse this project's newer .pbxproj format anyway (gem
   # limitation, not fixable by updating the gem).
+  # agvtool needs VERSIONING_SYSTEM = apple-generic, which this project doesn't
+  # set, so it silently no-ops - pass CURRENT_PROJECT_VERSION directly instead.
+  xcargs = "-skipPackagePluginValidation -skipMacroValidation"
+  xcargs += " CURRENT_PROJECT_VERSION=#{ENV['BUILD_NUMBER']}" if ENV["BUILD_NUMBER"]
+
   build_app(
     scheme: "PediFoods App",
     sdk: "iphoneos",
     export_method: ENV["BITRISE_DISTRIBUTION_METHOD"] || "app-store",
     xcconfig: "fastlane/AppStore.xcconfig",
-    xcargs: "-skipPackagePluginValidation -skipMacroValidation",
+    xcargs: xcargs,
     derived_data_path: "../.build/Darwin/DerivedData",
     output_directory: "../.build/fastlane/Darwin",
     skip_archive: ENV["FASTLANE_SKIP_ARCHIVE"] == "YES",